文件检查3次并退出shell脚本

Question

我想检查目录中的文件，如果有，然后将其推送到ssh服务器，检查服务器连接，如果文件不在那里，则每隔1分钟尝试3次，如果它来了(例如，在第二次参加会议时)，则再次尝试连接ssh并推送。否则检查3次尝试并退出

请检查我的以下代码，它在第一次尝试后停止(在第二次尝试期间，我正在使文件可用)

#!/bin/sh
echo "OK, start pushing the Userdetails to  COUPA now..."
cd /usr/App/ss/outbound/usrdtl/
n=0


      until [ $n -ge 3 ] || [ ! -f /usr/App/ss/outbound/usrdtl/USERS_APPROVERS_*.csv ]
      do 
      if [ -f /usr/App/ss/outbound/usrdtl/USERS_APPROVERS_*.csv ] ;  
      then 
      pushFiles()
      else
      n=$[$n+1]
      sleep 60
      echo " trying " $n "times " 
      fi
      done

pushFiles()
{
echo "File present Now try SSH connection"
while [ $? -eq 0 ];
do
    echo $(date);
     scpg3 -v /usr/App/ss/outbound/usrdtl/USERS_APPROVERS_*.csv <sshHost>:/Incoming/Users/
     if [ $? -eq 0 ]; then
        echo "Successfull" 
        echo $(date);
        echo "Successfull" >> /usr/App/ss/UserApproverDetails.log
        exit 1;
        else
            echo $(date);
            echo "Failed" >> /usr/App/ss/UserApproverDetails.log
            echo "trying again to push file.."
            scpg3 -v /usr/App/sg/outbound/usrdtl/USERS_APPROVERS_*.csv <ssh Host>:/Incoming/Users/
            echo $(date);   
        exit 1;
    fi
done
}

Answer 1

我已经试着为您简化这段代码。我希望它能有所帮助：

#!/bin/bash

outdir="/usr/App/ss/outbound/usrdtl"
logfile="/usr/App/ss/UserApproverDetails.log"
file_prefix="USERS_APPROVERS_"

function push_files() {
    echo "File present now try SSH connection"
    local attempts=1
    local retries=2
    date

    while [[ ${attempts} -lt ${retries} ]]; do
        if scp ${outdir}/${file_prefix}*.csv <sshHost>:/Incoming/Users/ ; then

            echo "Successful" | tee -a ${logfile}
            date
            exit 0
        else
            echo "Failed" >> ${logfile}
        fi
        attempts=$((attempts+1))
    do
    echo "scp failed twice" | tee -a ${logfile}
    exit 2
}

echo "OK, start pushing the Userdetails to  COUPA now..."
cd ${outdir}
attempts=1
retries=3
while [[ ${attempts} -lt ${retries} ]]; do
    echo "looking for files...attempt ${attempts}"
    if test -n "$(shopt -s nullglob; echo ${outdir}/${file_prefix}*.csv)"; then
        push_files()
    fi
    attempts=$((attempts+1))
    sleep 60
done
echo "Files were never found" | tee -a ${logfile}
exit 1

看看这段代码，告诉我它怎么没有做你想做的事情。这里最复杂的部分是nullglob内容，这是查看any file in a glob matches

此外，我通常使用bashisms。