试图更新ps_pagination类

Question

我有一个老版本的分页脚本，多年来一直为我服务，但是它几乎被开发人员抛弃了，我无法将mysql调用升级到mysqli，因为它是oop，我对它非常陌生。我的主要问题是我知道我需要更改什么，但是我无法理解使用$this-的语法。仅仅更改调用是不够的，当我添加参数时，我的编辑器会抱怨它。

当我改变的时候

$all_rs = @mysql_query($this->sql );

至

$all_rs = mysqli_query($this->conn, $this->sql );

(对于oop来说，这可能是完全错误的语法)，我被告知我缺少查询参数，或者我有未声明的vars。请记住，编辑器只看到了类，而没有看到vars被传递给它的值，所以我有点不知所措，不知道如何编写代码。

这是全班学生

<?php
/**
 * PHPSense Pagination Class
 *
 * PHP tutorials and scripts
 *
 * @package     PHPSense
 * @author      Jatinder Singh Thind
 * @copyright   Copyright (c) 2006, Jatinder Singh Thind
 * @link        http://www.phpsense.com
 */

// ------------------------------------------------------------------------


class PS_Pagination {
    var $php_self;
    var $rows_per_page = 10; //Number of records to display per page
    var $total_rows = 0; //Total number of rows returned by the query
    var $links_per_page = 5; //Number of links to display per page
    var $append = ""; //Paremeters to append to pagination links
    var $sql = "";
    var $debug = false;
    var $conn = false;
    var $page = 1;
    var $max_pages = 0;
    var $offset = 0;

    /**
     * Constructor
     *
     * @param resource $connection Mysql connection link
     * @param string $sql SQL query to paginate. Example : SELECT * FROM users
     * @param integer $rows_per_page Number of records to display per page. Defaults to 10
     * @param integer $links_per_page Number of links to display per page. Defaults to 5
     * @param string $append Parameters to be appended to pagination links 
     */

    function PS_Pagination($connection, $sql, $rows_per_page = 10, $links_per_page = 5, $append = "") {
        $this->conn = $connection;
        $this->sql = $sql;
        $this->rows_per_page = (int)$rows_per_page;
        if (intval($links_per_page ) > 0) {
            $this->links_per_page = (int)$links_per_page;
        } else {
            $this->links_per_page = 5;
        }
        $this->append = $append;
        $this->php_self = htmlspecialchars($_SERVER['PHP_SELF'] );
        if (isset($_GET['page'] )) {
            $this->page = intval($_GET['page'] );
        }
    }

    /**
     * Executes the SQL query and initializes internal variables
     *
     * @access public
     * @return resource
     */
    function paginate() {
        //Check for valid mysql connection
        if (! $this->conn || ! is_resource($this->conn )) {
            if ($this->debug)
                echo "MySQL connection missing<br />";
            return false;
        }

        //Find total number of rows
        $all_rs = @mysql_query($this->sql );
        if (! $all_rs) {
            if ($this->debug)
                echo "SQL query failed. Check your query.<br /><br />Error Returned: " . mysql_error();
            return false;
        }
        $this->total_rows = mysql_num_rows($all_rs );
        @mysql_close($all_rs );

        //Return FALSE if no rows found
        if ($this->total_rows == 0) {
            if ($this->debug)
                echo "Query returned zero rows.";
            return FALSE;
        }

        //Max number of pages
        $this->max_pages = ceil($this->total_rows / $this->rows_per_page );
        if ($this->links_per_page > $this->max_pages) {
            $this->links_per_page = $this->max_pages;
        }

        //Check the page value just in case someone is trying to input an aribitrary value
        if ($this->page > $this->max_pages || $this->page <= 0) {
            $this->page = 1;
        }

        //Calculate Offset
        $this->offset = $this->rows_per_page * ($this->page - 1);

        //Fetch the required result set
        $rs = @mysql_query($this->sql . " LIMIT {$this->offset}, {$this->rows_per_page}" );
        if (! $rs) {
            if ($this->debug)
                echo "Pagination query failed. Check your query.<br /><br />Error Returned: " . mysql_error();
            return false;
        }
        return $rs;
    }

    /**
     * Display the link to the first page
     *
     * @access public
     * @param string $tag Text string to be displayed as the link. Defaults to 'First'
     * @return string
     */
    function renderFirst($tag = 'First') {
        if ($this->total_rows == 0)
            return FALSE;

        if ($this->page == 1) {
            return '"previous-off">' . $tag;
        } else {
            return '"next"><a href="' . $this->php_self . '?page=1&amp;' . $this->append . '">' . $tag . '</a> ';
        }
    }

    /**
     * Display the link to the last page
     *
     * @access public
     * @param string $tag Text string to be displayed as the link. Defaults to 'Last'
     * @return string
     */
    function renderLast($tag = 'Last') {
        if ($this->total_rows == 0)
            return FALSE;

        if ($this->page == $this->max_pages) {
            return '"previous-off">' . $tag;
        } else {
            return '"next"><a href="' . $this->php_self . '?page=' . $this->max_pages . '&amp;' . $this->append . '">' . $tag . '</a>';
        }
    }

    /**
     * Display the next link
     *
     * @access public
     * @param string $tag Text string to be displayed as the link. Defaults to '>>'
     * @return string
     */
    function renderNext($tag = '&gt;&gt;') {
        if ($this->total_rows == 0)
            return FALSE;

        if ($this->page < $this->max_pages) {
            return '"next"><a href="' . $this->php_self . '?page=' . ($this->page + 1) . '&amp;' . $this->append . '">' . $tag . '</a>';
        } else {
            return '"next-off">' . $tag;
        }
    }

    /**
     * Display the previous link
     *
     * @access public
     * @param string $tag Text string to be displayed as the link. Defaults to '<<'
     * @return string
     */
    function renderPrev($tag = '&lt;&lt;') {
        if ($this->total_rows == 0)
            return FALSE;

        if ($this->page > 1) {
            return ' "next"><a href="' . $this->php_self . '?page=' . ($this->page - 1) . '&amp;' . $this->append . '">' . $tag . '</a>';
        } else {
            return '"previous-off">' . $tag;
        }
    }

    /**
     * Display the page links
     *
     * @access public
     * @return string
     */
    function renderNav($prefix = '<span class="page_link">', $suffix = '</span>') {
        if ($this->total_rows == 0)
            return FALSE;

        $batch = ceil($this->page / $this->links_per_page );
        $end = $batch * $this->links_per_page;
        if ($end == $this->page) {
            //$end = $end + $this->links_per_page - 1;
        //$end = $end + ceil($this->links_per_page/2);
        }
        if ($end > $this->max_pages) {
            $end = $this->max_pages;
        }
        $start = $end - $this->links_per_page + 1;
        $links = '';

        for($i = $start; $i <= $end; $i ++) {
            if ($i == $this->page) {
                $links .= $prefix . ' class="active">' . "$i"  . $suffix;
            } else {
                $links .= ' ' . $prefix . '><a href="' . $this->php_self . '?page=' . $i . '&amp;' . $this->append . '">' . $i . '</a>' . $suffix . ' ';
            }
        }

        return $links;
    }

    /**
     * Display full pagination navigation
     *
     * @access public
     * @return string
     */
    function renderFullNav() {
        return $this->renderFirst() . '&nbsp;' . $this->renderPrev() . '&nbsp;' . $this->renderNav() . '&nbsp;' . $this->renderNext() . '&nbsp;' . $this->renderLast();
    }

    /**
     * Set debug mode
     *
     * @access public
     * @param bool $debug Set to TRUE to enable debug messages
     * @return void
     */
    function setDebug($debug) {
        $this->debug = $debug;
    }
}
?>

对我应该如何格式化这些电话有什么想法吗？谢谢

Answer 1

这里，我修复了一些关于类的构造方式的基本内容，主要是尊重当前的使用标准和现代的oop结构。

然而，它的要点在于语句调用：

$all_rs = $this->conn->query($this->sql);

• PHP具有我们应该用作构造函数的__construct()函数。
• 在定义成员时使用私有、受保护和公共的。
• 使用类型提示来指定您的参数(php7提供了许多在php5中缺少的标量类型提示(例如int、string、float )，但是我们可以键入任何类。
• 不需要手动验证连接是否成功，也不需要检查错误。连接对象应该以所需的错误报告级别构建，mysqli实现之后将根据需要抛出异常。
• 永远不要在问询前使用相当可笑的“。根据我的经验，抑制错误消息并不是对数据库访问或编程进行推理的合理方法，而且只会导致艰难的调试。
• 使用setter注入(用于调试参数)也只会导致问题。将它作为构造函数参数可以确保所有分页对象的生命周期的正确行为。

，坏消息，

但是，这对于sql注入非常开放，因为我没有更改函数签名，因此可以在实际代码中继续使用它。通常，您会准备好，然后使用这些值执行语句，以利用参数化语句。