我已经得到了这个方法,如果SPListItem的某个字段是null,并且如果它是该属性的默认值,那么我要检查几次。有什么办法可以减少这个代码吗?谢谢
public List<Models.EmployeeInfo> GetEmployeeInfo(SPListItemCollection splic)
{
List<Models.EmployeeInfo> listEmployeeInfo = new List<Models.EmployeeInfo>();
foreach (SPListItem item in splic)
{
var employeeInfo = new Models.EmployeeInfo();
if (item["EmployeeName"] == null)
{
employeeInfo.EmployeeName = "";
}
else
{
employeeInfo.EmployeeName = item["EmployeeName"].ToString();
}
if (item["Position"] == null)
{
employeeInfo.Position = "";
}
else
{
employeeInfo.Position = item["Position"].ToString();
}
if (item["Office"] == null)
{
employeeInfo.Office = "";
}
else
{
employeeInfo.Office = item["Office"].ToString();
}
if (item["IsPublic"] == null)
{
employeeInfo.IsPublic = true;
}
else
{
employeeInfo.IsPublic = Convert.ToBoolean("IsPublic");
}
listEmployeeInfo.Add(employeeInfo);
}
return listEmployeeInfo;
}发布于 2015-12-09 17:03:47
试着做这样的事情:
public List<Models.EmployeeInfo> GetEmployeeInfo(SPListItemCollection splic)
{
var listEmployeeInfo = new List<Models.EmployeeInfo>();
foreach (SPListItem item in splic)
{
var employeeInfo = new Models.EmployeeInfo();
employeeInfo.EmployeeName = item["EmployeeName"] == null ? "" : item["EmployeeName"].ToString();
employeeInfo.Position = item["Position"] == null ? "" : item["Position"].ToString();
employeeInfo.Office = item["Office"] == null ? "" : item["Office"].ToString();
employeeInfo.IsPublic = item["IsPublic"] == null || Convert.ToBoolean("IsPublic");
listEmployeeInfo.Add(employeeInfo);
}
return listEmployeeInfo;
}发布于 2015-12-09 17:10:35
尝试将公共逻辑重构为函数。
employeeInfo.EmployeeName = ConditionalToString(item, "EmployeeName");
employeeInfo.Position = ConditionalToString(item, "Position");
employeeInfo.Office = ConditionalToString(item, "Office");
employeeInfo.IsPublic = item[attrName] == null ? false : Convert.ToBoolean("IsPublic");
string ConditionalToString(SPListItem item, string attrName)
{
return (item[attrName] == null ? "" : item[attrName].ToString());
}零聚结算子将无法工作,因为itemattrName和"“是不同的类型,所以这样的东西无法工作:(item[attrName] ?? "").ToString() (在这种情况下dynamic会有用吗?)我不经常使用它)。
TLJ的评论是一种替代的解决方案,可以在其中发生这种逻辑(尽管您在那里仍然会有相同的重复)。
发布于 2015-12-09 17:21:21
我同意这里给出的另一个答案,即使用三元运算符。奇怪的是,我昨天也在学习同样的东西。您可以而且应该在这里使用三元运算符,而不是if - else。
优势?
employeeInfo对象以将其放入列表)。此外,您可以将employeeInfo对象创建重构为另一个方法,并保持当前方法的清洁(如下所示):
public List<Models.EmployeeInfo> GetEmployeeInfo(SPListItemCollection splic)
{
var listEmployeeInfo = new List<Models.EmployeeInfo>();
foreach (SPListItem splicItem in splic)
{
listEmployeeInfo.Add(CreateEmployeeInfoFromItem(splicItem));
}
return listEmployeeInfo;
}
private static Models.EmployeeInfo CreateEmployeeInfoFromItem(SPListItem item)
{
var employeeInfo = new Models.EmployeeInfo();
employeeInfo.EmployeeName = item["EmployeeName"] == null ? "" : item["EmployeeName"].ToString();
employeeInfo.Position = item["Position"] == null ? "" : item["Position"].ToString();
employeeInfo.Office = item["Office"] == null ? "" : item["Office"].ToString();
employeeInfo.IsPublic = item["IsPublic"] == null || Convert.ToBoolean("IsPublic");
return employeeInfo;
}https://stackoverflow.com/questions/34184602
复制相似问题