首页
学习
活动
专区
圈层
工具
发布
社区首页 >问答首页 >内存泄漏C++管理中的问题

内存泄漏C++管理中的问题
EN

Stack Overflow用户
提问于 2015-11-01 10:49:05
回答 3查看 125关注 0票数 1

我没有得到任何错误或类似的东西,但问题是,无论我做什么,我无法消除这些内存泄漏。我找到的唯一帮助我的解决方案是在每个方法之后添加delete[] vector1,但是不允许我修改代码的那个部分。在代码中,您可以看到注释和我可以添加新指令的区域。我的问题有什么解决办法吗?

这是代码:

代码语言:javascript
复制
#include<iostream>
using namespace std;

/*YOU CAN'T ADD NEW METHODS*/
/*YOU CAN ONLY MODIFY THE BODY OF THE METHODS*/

//read array from the console - number of elements and the elements
int * readVectorVersion1(int * noElements) {
    int *vector1;
    vector1 = new int[*noElements + 1];
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector1[i];

    }
    return vector1;
}
//read array from the console - number of elements and the elements
void readVectorVersion2(int ** vector, int* noElements) {
    *vector = new int[*noElements + 1];
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> (*vector)[i];
    }
}
//read array from the console - number of elements and the elements
void readVectorVersion3(int *& vector, int& noElements) {
    vector = new int[noElements + 1];
    for (int i = 0; i < noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector[i];
    }
}

//read array from the console - number of elements and the elements
int * readVectorVersion4(int& noElements) {
    int *vector1;
    vector1 = new int[noElements + 1];
    for (int i = 0; i < noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector1[i];
    }
    return vector1;
}

//read static array from the console - number of elements and the elements
void readStaticVector(int vector[], int * noElements) {
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector[i];
    }
}

//print the elements of the array
void afisareVector(int* vector, int noElements) {
    cout << endl << "Vector:" << endl;
    for (int i = 0; i < noElements; i++)
        cout << vector[i] << " ";

}


//read a name from the console
char* citesteNume() {
    char temp[200];
    char * nume;
    cout << endl << "Your name:";
    cin >> temp;
    nume = new char[strlen(temp) + 1];
    strcpy(nume, temp);

    return nume;
}

//read a name from the console
void citesteNume(char* nume) {


    cout << endl << "Your name:";
    cin >> nume;


}
//METHODS THAT ADDS AN ELEMENT (THAT IS GIVEN) TO AN EXISTING ARRAY
//FIRST
void adaugaElementNou(int** vector, int* noElemente, int elementNou) {
    (*vector) = new int[*noElemente + 2];
    for (int i = 0; i < *noElemente; i++)
        (*vector)[i] = i;

    (*vector)[*noElemente] = elementNou;

}
//SECOND
int * adaugaElementNou(int& noElemente, int elementNou) {
    int *vector;
    vector = new int[noElemente + 2];
    for (int i = 0; i < noElemente; i++)
        vector[i] = i;
    vector[noElemente] = elementNou;
    return vector;

}
//THIRD
int * adaugaElementNou(int* noElemente, int elementNou) {
    int *vector;
    vector = new int[(*noElemente) + 2];
    for (int i = 0; i < *noElemente; i++)
        vector[i] = i;
    vector[*noElemente] = elementNou;
    return vector;

}



//THE PROGRAM MUST RUN AND NOT GENERATE ANY ERRORS OR MEMORY-LEAKS
void main() {
    //YOU CAN'T ADD NEW VARIABLES

    int * vector1;
    int vector2[50];
    int nrElementeVector1=3;
    int nrElementeVector2=3;

    //YOU CAN ADD NEW INSTRUCTIONS
    // ...
    vector1 = new int[nrElementeVector1 + 1];
    for (int i = 0; i < nrElementeVector1; i++)
        vector1[i] = i;
    for (int i = 0; i < nrElementeVector2; i++)
        vector2[i] = i;
    //YOU CAN'T MODIFY THE FOLLOWING CODE

    afisareVector(vector1, nrElementeVector1);
    afisareVector(vector2, nrElementeVector2);
    //delete[]vector1; /*This instruction is added by me but i`m not allowed to modify this area of the code*/
    vector1 = readVectorVersion1(&nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    //delete[]vector1;
    readVectorVersion2(&vector1, &nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    //delete[]vector1;
    readVectorVersion3(vector1, nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    //delete[]vector1;
    vector1 = readVectorVersion4(nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    //delete[]vector1;
    readStaticVector(vector2, &nrElementeVector2);
    afisareVector(vector2, nrElementeVector2);

    char* string1;
    char string2[50];

    string1 = citesteNume();
    cout << endl << "Hello " << string1;
    //delete[]string1; /*THIS IS NOT ALLOWED HERE*/
    citesteNume(string2);
    cout << endl << "Hello " << string2;

    vector1 = adaugaElementNou(nrElementeVector1, 99);
    afisareVector(vector1, nrElementeVector1+1);
    //delete[]vector1;
    adaugaElementNou(&vector1, &nrElementeVector1, 55);
    afisareVector(vector1, nrElementeVector1+1);
    //delete[]vector1;
    vector1 = adaugaElementNou(&nrElementeVector1, 77);
    afisareVector(vector1, nrElementeVector1+1);
    //delete[]vector1;

    //YOU CAN ADD NEW INSTRUCTIONS HERE
    // ...

    delete[] vector1; //I`ve tried to use delete here because I didn`t knew what else i should do, but I know that it makes no sense(and it`s not working);
    delete[] string1;

    //THE FOLLOWING CODE CHECKS IF THERE ARE ANY MEMORYLEAKS
    _CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_FILE);
    _CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDOUT);
    _CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_FILE);
    _CrtSetReportFile(_CRT_ERROR, _CRTDBG_FILE_STDOUT);
    _CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_FILE);
    _CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDOUT);
    _CrtDumpMemoryLeaks();

    //YOU CAN'T MODIFY THE FOLLOWING CODE
    vector1 = NULL;
    string1 = NULL;
    cout << endl << "In this moment there are no memory-leaks!";
}
EN

回答 3

Stack Overflow用户

回答已采纳

发布于 2015-11-01 12:48:04

对于string1来说,它很简单,您可以只需:

代码语言:javascript
复制
delete[] string1;

这就是我认为你应该和vector1打交道的地方:

代码语言:javascript
复制
void afisareVector(int* vector, int noElements) {
    cout << endl << "Vector:" << endl;
    for (int i = 0; i < noElements; i++)
        cout << vector[i] << " ";

    // A very dirty hack, PLEASE **NEVER** USE IT.
    static int callIndex = 0;
    if(callIndex != 1 && callIndex != 6)
        delete[] vector;
    ++callIndex;
}

瓦砾摘要:

代码语言:javascript
复制
==20937== HEAP SUMMARY:
==20937==     in use at exit: 0 bytes in 0 blocks
==20937==   total heap usage: 9 allocs, 9 frees, 144 bytes allocated
==20937== 
==20937== All heap blocks were freed -- no leaks are possible
==20937== 
==20937== For counts of detected and suppressed errors, rerun with: -v
==20937== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

编辑:我改变主意了。上面的例子是你能做什么,这就是你应该做的:

注1:这次黑客攻击让我觉得更脏。

注2:为了编译它,我不得不删除所有特定于微软的内容,并使用val差生进行泄漏检查。

代码语言:javascript
复制
#include<iostream>
#include<cstring>
using namespace std;

/*YOU CAN'T ADD NEW METHODS*/
/*YOU CAN ONLY MODIFY THE BODY OF THE METHODS*/

//read array from the console - number of elements and the elements
int * readVectorVersion1(int * noElements) {
    static int vector1[50];
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector1[i];

    }
    return vector1;
}
//read array from the console - number of elements and the elements
void readVectorVersion2(int ** vector1, int* noElements) {
    static int vector [50];
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector[i];
    }
    *vector1 = vector;
}
//read array from the console - number of elements and the elements
void readVectorVersion3(int *& vector1, int& noElements) {
    static int vector [50];
    for (int i = 0; i < noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector[i];
    }
    vector1 = vector;
}

//read array from the console - number of elements and the elements
int * readVectorVersion4(int& noElements) {
    static int vector1 [50];
    for (int i = 0; i < noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector1[i];
    }
    return vector1;
}

//read static array from the console - number of elements and the elements
void readStaticVector(int vector[], int * noElements) {
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector[i];
    }
}

//print the elements of the array
void afisareVector(int* vector, int noElements) {
    cout << endl << "Vector:" << endl;
    for (int i = 0; i < noElements; i++)
        cout << vector[i] << " ";
}


//read a name from the console
char* citesteNume() {
    char temp[200];
    char * nume;
    cout << endl << "Your name:";
    cin >> temp;
    nume = new char[strlen(temp) + 1];
    strcpy(nume, temp);

    return nume;
}

//read a name from the console
void citesteNume(char* nume) {


    cout << endl << "Your name:";
    cin >> nume;


}
//METHODS THAT ADDS AN ELEMENT (THAT IS GIVEN) TO AN EXISTING ARRAY
//FIRST
void adaugaElementNou(int** vector, int* noElemente, int elementNou) {
    static int vector1 [50];
    for (int i = 0; i < *noElemente; i++)
        vector1[i] = i;

    vector1[*noElemente] = elementNou;
    *vector = vector1;
}
//SECOND
int * adaugaElementNou(int& noElemente, int elementNou) {
    static int vector [50];
    for (int i = 0; i < noElemente; i++)
        vector[i] = i;
    vector[noElemente] = elementNou;
    return vector;
}
//THIRD
int * adaugaElementNou(int* noElemente, int elementNou) {
    static int vector [50];
    for (int i = 0; i < *noElemente; i++)
        vector[i] = i;
    vector[*noElemente] = elementNou;
    return vector;
}



//THE PROGRAM MUST RUN AND NOT GENERATE ANY ERRORS OR MEMORY-LEAKS
int main() {
    //YOU CAN'T ADD NEW VARIABLES

    int * vector1;
    int vector2[50];
    int nrElementeVector1=3;
    int nrElementeVector2=3;

    //YOU CAN ADD NEW INSTRUCTIONS
    for (int i = 0; i < nrElementeVector2; i++)
        vector2[i] = i;
    vector1 = vector2;
    //YOU CAN'T MODIFY THE FOLLOWING CODE

    afisareVector(vector1, nrElementeVector1);
    afisareVector(vector2, nrElementeVector2);
    vector1 = readVectorVersion1(&nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    readVectorVersion2(&vector1, &nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    readVectorVersion3(vector1, nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    vector1 = readVectorVersion4(nrElementeVector1);
    afisareVector(vector1, nrElementeVector1);
    readStaticVector(vector2, &nrElementeVector2);
    afisareVector(vector2, nrElementeVector2);

    char* string1;
    char string2[50];

    string1 = citesteNume();
    cout << endl << "Hello " << string1;
    citesteNume(string2);
    cout << endl << "Hello " << string2;

    vector1 = adaugaElementNou(nrElementeVector1, 99);
    afisareVector(vector1, nrElementeVector1+1);
    adaugaElementNou(&vector1, &nrElementeVector1, 55);
    afisareVector(vector1, nrElementeVector1+1);
    vector1 = adaugaElementNou(&nrElementeVector1, 77);
    afisareVector(vector1, nrElementeVector1+1);

    //YOU CAN ADD NEW INSTRUCTIONS HERE
    // ...

    delete[] string1;

    //YOU CAN'T MODIFY THE FOLLOWING CODE
    vector1 = NULL;
    string1 = NULL;
}

瓦兰产出:

代码语言:javascript
复制
==21224== HEAP SUMMARY:
==21224==     in use at exit: 0 bytes in 0 blocks
==21224==   total heap usage: 1 allocs, 1 frees, 2 bytes allocated
==21224== 
==21224== All heap blocks were freed -- no leaks are possible
==21224== 
==21224== For counts of detected and suppressed errors, rerun with: -v
==21224== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

编辑:我想出了第三个(甚至更脏)的解决方案,但我已经厌倦了所有这些黑客攻击,无法编写完整的版本。下面是一个示例:

代码语言:javascript
复制
int * readVectorVersion1(int * noElements) {
    static int *vector1 = NULL;
    delete[] vector1;
    if (noElements < 0)
        return NULL;
    vector1 = new int[*noElements + 1];
    for (int i = 0; i < *noElements; i++)
    {
        cout << endl << "Vector1[" << i + 1 << "]=";
        cin >> vector1[i];

    }
    return vector1;
}

// ...

int main() {
    // ...
    // Just before _CrtSetReportMode
    nrElementeVector1 = -1;
    readVectorVersion1(*nrElementeVector1);
    // ..
}
票数 0
EN

Stack Overflow用户

发布于 2015-11-01 10:58:54

我认为这个任务是不可能完成的。线

代码语言:javascript
复制
vector1 = readVectorVersion1(&nrElementeVector1);

当vector1持有动态分配的资源时执行。在这一点上造成无法恢复的泄漏。以下情况也是如此

代码语言:javascript
复制
readVectorVersion2(&vector1, &nrElementeVector1);
票数 0
EN

Stack Overflow用户

发布于 2015-11-01 11:17:33

vector1指针在代码中被覆盖,您可能不会修改它,因此很明显,它可能不是动态分配内存的唯一指针,否则它会泄漏,在分配的限制范围内,您无法阻止它。

因此,让我们探索使用静态对象来保存指针的可能性。为了简单起见,我将使用std::vector,但如果愿意,可以使用动态内存的静态指针。在这种情况下,需要手动管理内存。

代码语言:javascript
复制
int * readVectorVersion1(int * noElements) {
    static std::vector<int> vector1;
    vector1.resize(*noElements);

    // initialize the way you want to

    return vector1.data();
    // return &vector1[0]; // use this if you use older version of c++ than c++11
}

然后就到了。当静态对象被销毁时,内存将被释放。当然,这限制了您可以使用该函数进行的操作。您不能再分配两个单独的数组,因为后续调用将使用相同的向量。但是这个作业不需要,所以我想这就是你的老师所要求的。

票数 0
EN
页面原文内容由Stack Overflow提供。腾讯云小微IT领域专用引擎提供翻译支持
原文链接:

https://stackoverflow.com/questions/33461372

复制
相关文章

相似问题

领券
问题归档专栏文章快讯文章归档关键词归档开发者手册归档开发者手册 Section 归档