在SunRPC上发送带缓冲区的链表(c)

Question

在过去的几天里，我一直在为以下问题而头疼:我想在SunRPC上发送一个任意大小/类型的文件。在客户端，我将文件读取到一个链接列表中，每个节点都包含一个大小为1024的缓冲区。如果在通过RPC发送缓冲区之前打印所有缓冲区，则得到正确的输出(即打印整个文件)。但是，当我通过RPC发送它并打印服务器端的所有缓冲区时，最后一个节点会被错误地打印出来，就好像它没有被正确传输一样。

我已经用一个大型.txt文件(100,5kB)测试了我的代码，在这里，它看起来确实有效。但是，对于一个.pdf文件(7,9kB)，它没有。

以下是我的(相关)代码：

.x文件：

struct node {
    string buf<>;
    long bytes;
    struct node* next;
};

struct paper {
    string author<>;
    string title<>;
    struct node* file;
    struct paper* next;
};

typedef long add_out;

program PAPERSERVER_PROG {
    version PAPERSERVER_VERS {
        add_out ADDPAPER(paper) = 1;
    } = 1;
} = 0x20001234;

C：(当我在函数末尾打印所有缓冲区时，输出是正确的)

#define BUF_SIZE 1024

void add_paper(char** argv, CLIENT* cl) {
    struct paper in;
    add_out *out;
    struct node* tmp;
    struct node* tmp2;
    struct node start;
    char buf[BUF_SIZE];
    size_t read;

    // Open the file
    FILE *fp = fopen(argv[5], "rb");
    if (fp == NULL) {
        perror("fopen");
        exit(EXIT_FAILURE);
    }

    in.author = strdup(argv[3]);
    in.title = strdup(argv[4]);
    in.file = &start;
    in.next = NULL;

    bzero(buf, BUF_SIZE);
    read = fread(buf, 1, BUF_SIZE, fp);
    if (ferror(fp)) {
        perror("fread error");
        exit(2);
    }

    tmp = &start;
    tmp->buf = calloc(BUF_SIZE, 1);
    if (tmp->buf == NULL) {
        perror("malloc tmp->buf");
        exit(2);
    }

    tmp->bytes = read;
    tmp->buf = memcpy(tmp->buf, buf, read);

    // Cycle until end of file
    while (!feof(fp)) {
        bzero(buf, BUF_SIZE);

        tmp->next = (struct node*) calloc(sizeof(struct node), 1);
        if (tmp->next == NULL) {
            perror("malloc tmp->next");
            exit(2);
        }

        tmp = tmp->next;

        read = fread(buf, 1, BUF_SIZE, fp);
        if (ferror(fp)) {
            perror("fread error");
            exit(2);
        }

        printf("read:%zu\n", read);

        tmp->buf = calloc(BUF_SIZE+1, 1);
        if (tmp->buf == NULL) {
            perror("malloc tmp->buf");
            exit(2);
        }

        tmp->bytes = read;
        tmp->buf = memcpy(tmp->buf, buf, read);      
    }
    tmp->next = NULL;

    out = addpaper_1(&in, cl);
    if (out == NULL) {
        printf("Error: %s\n", clnt_sperror(cl, argv[1]));
    } else {
        printf("%ld\n", *out);
    }

    clnt_destroy(cl);
}

paperserver.c (这里的输出错误)

add_out* addpaper_1_svc(paper* in, struct svc_req* rqstp) { 
    static add_out out;
    struct node* file;
    long written;

    file = in->file;
    char* buf;

    while (file != NULL) {
        buf = calloc(BUF_SIZE + 1, 1);
        buf = memcpy(buf, file->buf, file->bytes);

        written = fwrite(buf, 1, file->bytes, stdout);

        if (ferror(stdout)) {
            perror("fwrite error");
            exit(2);
        } 

        file = file->next;
    }

    out = 0;

    return &out;
}

编辑：

若要指定有关预期输出的更多信息，请执行以下操作。我希望我在服务器上发送的文件的输出与调用cat <filename>完全一样。但是，输出的顺序似乎是错误的。最后一个缓冲区似乎被文件开头的某些内容覆盖。这与一个.pdf文件一起使用。对于另一个.pdf，它是工作的，而对于.txt，它是工作的，但是对于一个.jpg，它不工作。当我得到输出的md5sum时，它会随每次调用而改变。这让我觉得它打印的字节实际上不是由我的程序初始化的。此外，当我使用valgrind时，我会得到以下错误(仅针对不能正确工作的文件)：

==2375== Invalid read of size 8
==2375==    at 0x4C2F790: memcpy@@GLIBC_2.14 (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2375==    by 0x400D3E: addpaper_1_svc (paperserver.c:38)
==2375==    by 0x40128D: paperserver_prog_1 (paperserver_svc.c:76)
==2375==    by 0x4F626D0: svc_getreq_common (svc.c:534)
==2375==    by 0x4F6281D: svc_getreq_poll (svc.c:460)
==2375==    by 0x4F65BFE: svc_run (svc_run.c:96)
==2375==    by 0x401437: main (paperserver_svc.c:114)
==2375==  Address 0x527af48 is 392 bytes inside a block of size 394 alloc'd
==2375==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2375==    by 0x4F64D04: xdr_string (xdr.c:788)
==2375==    by 0x401487: xdr_node (paperserver_xdr.c:13)
==2375==    by 0x4F656B7: xdr_pointer (xdr_ref.c:84)
==2375==    by 0x40155C: xdr_paper (paperserver_xdr.c:31)
==2375==    by 0x401268: paperserver_prog_1 (paperserver_svc.c:72)
==2375==    by 0x4F626D0: svc_getreq_common (svc.c:534)
==2375==    by 0x4F6281D: svc_getreq_poll (svc.c:460)
==2375==    by 0x4F65BFE: svc_run (svc_run.c:96)
==2375==    by 0x401437: main (paperserver_svc.c:114)
==2375== 
==2375== Invalid read of size 8
==2375==    at 0x4C2F79E: memcpy@@GLIBC_2.14 (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2375==    by 0x400D3E: addpaper_1_svc (paperserver.c:38)
==2375==    by 0x40128D: paperserver_prog_1 (paperserver_svc.c:76)
==2375==    by 0x4F626D0: svc_getreq_common (svc.c:534)
==2375==    by 0x4F6281D: svc_getreq_poll (svc.c:460)
==2375==    by 0x4F65BFE: svc_run (svc_run.c:96)
==2375==    by 0x401437: main (paperserver_svc.c:114)
==2375==  Address 0x527af50 is 6 bytes after a block of size 394 alloc'd
==2375==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2375==    by 0x4F64D04: xdr_string (xdr.c:788)
==2375==    by 0x401487: xdr_node (paperserver_xdr.c:13)
==2375==    by 0x4F656B7: xdr_pointer (xdr_ref.c:84)
==2375==    by 0x40155C: xdr_paper (paperserver_xdr.c:31)
==2375==    by 0x401268: paperserver_prog_1 (paperserver_svc.c:72)
==2375==    by 0x4F626D0: svc_getreq_common (svc.c:534)
==2375==    by 0x4F6281D: svc_getreq_poll (svc.c:460)
==2375==    by 0x4F65BFE: svc_run (svc_run.c:96)
==2375==    by 0x401437: main (paperserver_svc.c:114)  

Answer 1

您正在使用string buf<>来包含文件数据。字符串将被第一个零字节终止，因此如果数据中间有任何零字节( PDF文件可能会这样做，但文本文件不会)，那么完整的数据就不会被写入。

(请注意，RPC不可能知道node中有多少数据-您碰巧将数据放入bytes，但是RPC基础结构不知道.)。

要解决这个问题，您需要将buf改为opaque：

opaque buf<>;

...and对C代码进行相应的更改，按照

buf.buf_val = calloc(...);
buf.buf_len = num_bytes_read;