万维网表格

Question

我正在学习PHP，现在我正在创建一个完整的web表单，该表单将一个新的订阅者记录添加到时事通讯数据库中的订阅者表中。这是我第一次在这个网站上，所以请原谅任何n00biness。

注释解释了决定表单是否将被处理的代码部分。我不确定它是否需要进入验证提交的表单数据的if..else语句，或者它是否在它自己的if..else中进行验证。

当我把它放在验证中时，html表单会显示，但是当我点击submit时，所有的信息都会刷新，什么也不会发生。

当我把它放在验证之后，html表单没有显示，我会收到一个错误，上面写着未定义的变量: FormErrorCount。然后它告诉我我应该得到的id号，但是我没有输入名称或电子邮件(因为html表单没有显示)，这是空的。

有一个包含文件，但这是很好的。

我相信一旦这个问题解决了，我会有一种想扇自己耳光的感觉，但是我盯着屏幕已经太久了。谢谢

<?php

    $ShowForm = FALSE;
    $SubscriberName = "";
    $SubscriberEmail = "";

    if (isset($_POST['submit'])) {
        $FormErrorCount = 0;
        if (isset($_POST['SubName'])) {
            $SubscriberName = stripslashes($_POST['SubName']);
            $SubscriberName = trim($SubscriberName);
            if (strlen($SubscriberName) == 0) {
                echo "<p>You must include your name</p>\n";
                ++$FormErrorCount;
            }
        }else{
            echo "<p>Form submittal error (No 'SubName' field)!</p>\n";
            ++$FormErrorCount;
        }
        if (isset($_POST['SubEmail'])) {
            $SubscriberEmail = stripslashes($_POST['SubEmail']);
            $SubscriberEmail = trim($SubscriberEmail);
            if (strlen($SubscriberEmail == 0)) {
                echo "<p>You must include your email address!</p>\n";
                ++$FormErrorCount;
            }
        }else{
            echo "<p>Form submittal error (No 'SubEmail' field)!</p>\n";
            ++$FormErrorCount;
        }
        //CODE BELOW IS THE SAME AS THE COMMENTED OUT CODE TOWARDS THE END. NOT SURE WHERE IT GOES.

        if ($FormErrorCount == 0) {
            $ShowForm = FALSE;
            include("inc_db_newsletter.php");
            if ($DBConnect !== FALSE) {
                $TableName = "subscribers";
                $SubscriberDate = date("Y-m-d");
                $SQLstring = "INSERT INTO $TableName " .
                             " (name, email, subscribe_date) " .
                             " VALUES('$SubscriberName', '$SubscriberEmail', '$SubscriberDate')";
                $QueryResult = @mysql_query($SQLstring, $DBConnect);
                if ($QueryResult === FALSE) {
                    echo "<p>Unable to insert the values into the subscriber table.</p>" .
                        "<p>Error code " . mysql_errno($DBConnect) . ": " .
                        mysql_error($DBConnect) . "</p>";
                }else{
                $SubscriberID = mysql_insert_id($DBConnect);
                echo "<p>" . htmlentities($SubscriberName) . ", you are now subscribed to our
                     newsletter.<br />";
                echo "Your subscriber ID is $SubscriberID.<br />";
                echo "Your email address is " . htmlentities($SubscriberEmail) . ".</p>";
                }
                mysql_close($DBConnect);              
            }
        }else{
            $ShowForm = TRUE;
        }

        //CODE ABOVE IS THE SAME AS THE COMMENTED OUT CODE TOWARDS THE END. NOT SURE WHERE IT GOES.
    }else{
        $ShowForm = TRUE;
    }

    /* CODE BELOW IS SAME AS THE CODE BETWEEN THE COMMENTS ABOVE, BUT NOT SURE WHERE IT BELONGS

    if ($FormErrorCount == 0) {
        $ShowForm = FALSE;
        include("inc_db_newsletter.php");
        if ($DBConnect !== FALSE) {
            $TableName = "subscribers";
            $SubscriberDate = date("Y-m-d");
            $SQLstring = "INSERT INTO $TableName (name, email, subscribe_date) " .
                         "VALUES ('$SubscriberName', '$SubscriberEmail', '$SubscriberDate')";
            $QueryResult = @mysql_query($SQLstring, $DBConnect);
            if ($QueryResult === FALSE) {
                echo "<p>Unable to insert the values into the subscriber table.</p>" .
                     "<p>Error code " . mysql_errno($DBConnect) . ": " .
                     mysql_error($DBConnect) . "</p>";
            }else{
                $SubscriberID = mysql_insert_id($DBConnect);
                echo "<p>" . htmlentities($SubscriberName) . ", you are now subscribed to our
                     newsletter.<br />";
                echo "Your subscriber ID is $SubscriberID.<br />";
                echo "Your email address is " . htmlentities($SubscriberEmail) . ".</p>";
            }
            mysql_close($DBConnect);              
        }
    }else{
        $ShowForm = TRUE;
    }

    */CODE ABOVE IS SAME AS THE CODE BETWEEN THE COMMENTS ABOVE SECTION, BUT NOT SURE WHERE IT BELONGS

//HTML PORTION  
    if ($ShowForm) {
        ?>
        <form action = "NewsletterSubscribe.php" method = "POST">
            <p><strong>Your Name: </strong>
                <input type = "text" name = "SubName" value = "<?php echo $SubscriberName; ?>" /></p>
            <p><strong>Your Email Address: </strong>
                <input type = "text" name = "SubEmail" value = "<?php echo $SubscriberEmail; ?>" /></p>
            <p><input type = "Submit" name = "Submit" value = "Submit" /></p>
        </form>
        <?php
    }

?>

Answer 1

您的代码目前忽略了最后的ShowForm部分，其结构如下：

if this is a submit {
    validate the form data
    if there are no errors {
        save the form data
    }
}

这看起来很合理。也许你的表格不是作为帖子提交的？检查您的<form action>，并使用Firebug确保表单数据正在提交。

如果要移动错误检查，则需要：

if this is a submit {
    validate the form data
}
if there are no errors {
    save the form data
}

这是错误的，因为如果没有提交表单，那么您就没有错误(因此出现了“未定义变量”错误)，然后它将尝试保存不存在的表单数据。