_popen崩溃[Windows]

Question

我是C语言的新手(实际上是所有编译语言的新手)，下面您将看到我的可怕代码，在这里我尝试接收一个命令，然后我希望执行它(尚未实现)。

我在_popen函数上摘取了微软的示例代码，并对其进行了修改(非常轻微)，但由于某种原因，我的程序在收到命令后崩溃。如果我将这段代码移动到命令接收部分的上方，它就会工作得很好。我是不是在重写另一个内存地址什么的？

如果您需要服务器(用python编写)，请告诉我。希望你能帮助有需要的菜鸟。

#include <winsock2.h>
#include <stdio.h>
#include <windows.h>

int sendall(int sock, char *message, unsigned int size);
int connect(char address[], short port);
char* recvall(int sock, unsigned int *msgsize);


int main(){
    char address[] = "127.0.0.1";
    short port = 1234;
    int wait = 5000;

    //Connect back
    int sock = 1;
    printf("Connecting...\n");
    sock = connect(address, port);
    while(sock == 1){
        WSACleanup();
        Sleep(wait);
        sock = connect(address, port);
    }

    printf("Succesfully conneted\n");

    char test[] = "ABCDEFGH";
    sendall(sock,test, 8);

    unsigned int msgsize;
    char *msg = recvall(sock,&msgsize);


    printf("%s\n", msg);
    printf("%d\n", msgsize);


    //RUN COMMAND

    char   psBuffer[128];
    FILE   *pPipe;


    printf("There\n");

    if( (pPipe = _popen( "ipconfig", "rt" )) == NULL )
        exit( 1 );

    printf("Out\n");

    while(fgets(psBuffer, 128, pPipe)){
        printf(psBuffer);
    }


    if (feof( pPipe)){
        printf( "\nProcess returned %d\n", _pclose( pPipe ) );
    }else{
        printf( "Error: Failed to read the pipe to the end.\n");
    }

    //RUN COMMAND END 

    Sleep(10000);
    return 0;
}

int sendall(int sock, char *message, unsigned int size){

    //Send size packet
    char sizepacket[12];
    sprintf (sizepacket, "%012u",size);
    send(sock, sizepacket, 12, 0);

    //Send data
    unsigned int left = size;
    unsigned int offset = 0;
    while(left>0){
        if(left<1024){
            send(sock, (message+offset), left, 0);
            left = 0;
        }else{
            send(sock, (message+offset), 1024, 0);
            offset = offset + 1024;
            left = left - 1024;
        }
    }
    return 0;
}

char* recvall(int sock, unsigned int *size){
    char *message;

    //Get size packet
    char sizebuff[24];
    memset (&sizebuff,0,24);
    recv(sock, sizebuff, 12, 0);
    *size = atoi(sizebuff);

    //Alloc space for message
    message = (char*)  malloc(*size + 1);
    memset(message,0,1024);

    //Get data
    unsigned int left = *size;
    unsigned int offset = 0;
    while(left>0){
        if(left<1024){
            recv(sock, (message+offset), left, 0);
            left = 0;
        }else{
            recv(sock, (message+offset), 1024, 0);
            offset = offset + 1024;
            left = left - 1024;
        }
    }
    return message;
}



int connect(char address[], short port){
    int returnvalue;

    WSADATA wsaData;

    returnvalue = WSAStartup(MAKEWORD(2,2), &wsaData);
    if(returnvalue != 0){
        return 1;
    }

    int sock;
    sock = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP);
    if(sock == 0){
        return 1;
    }


    //Create struct
    struct sockaddr_in clientService;
    clientService.sin_family = AF_INET;
    clientService.sin_addr.s_addr = inet_addr(address);
    clientService.sin_port = htons(port);


    returnvalue = connect(sock, (SOCKADDR*) &clientService, sizeof(clientService));
    if (returnvalue != 0){
        closesocket(sock);
        WSACleanup();
        return 1;
    }

    return sock;
}

Answer 1

您的popen似乎不依赖于您的套接字通信。

请描述您的服务器发送的消息(已转储？)

请看一下您的recvall()函数。从套接字中读取12个字节，将其转换为int，并将许多字节的malloc存储为* size，然后将消息缓冲区(仅为malloc‘’ed)存储为1024大小。然后，在缓冲区中接收一条消息，但不设置任何保护，以确保不会超出消息*大小的末尾。

int main(){
    //...
    unsigned int msgsize;
    char *msg = recvall(sock,&msgsize);
    printf("%d\n", msgsize);
    printf("%s\n", msg);
    return 0;
}

char* recvall(int sock, unsigned int *size){
    char *message;
    //Get size packet
    char sizebuff[24];
    memset (&sizebuff,0,24);
    recv(sock, sizebuff, 12, 0);
    *size = atoi(sizebuff);
    printf("size: %d\n",*size);fflush(stdout);
    //Alloc space for message
    message = (char*)  malloc(*size + 1);
    memset(message,0,1024); //why 1024? why not *size?
    //Get data
    unsigned int left = *size;
    unsigned int offset = 0;
    while(left>0){
        if(left<1024){
            recv(sock, (message+offset), left, 0);
            left = 0;
        }else{
            recv(sock, (message+offset), 1024, 0); //why 1024?
            offset = offset + 1024; //again, why 1024?, this is > 1024
            left = left - 1024;
        }
    }
    return message;
}

Answer 2

您的示例不会在我的系统上编译，因为您有两个版本的connect()函数--本地调用和系统版本，它们是从本地connect()函数本身调用的：

returnvalue = connect(sock, (SOCKADDR*) &clientService, sizeof(clientService));

尝试将本地版本更改为不同的名称，例如xconnect()。我很惊讶你的编译器允许这样做。