新用户创建脚本错误

Question

下面列出的脚本似乎无法解决这个问题。我正在尝试为我所在的UNIX类创建一个交互式登录脚本。我基本上是在构建一个传递到useradd中的命令。当我将命令传递到命令行(同时添加sudo)时，该命令正常工作，但当我试图从脚本(它生成复制/粘贴到命令行的文本)运行它时，它会给我一些错误.在这一点上，我不知道下一步该做什么来解决这个问题。

错误：

useradd -m --user-group jaredm2 #command that is attempting to run...
useradd: invalid option -- ' '
Usage: useradd [options] LOGIN
....rest of useradd error text....

脚本：

#!/bin/bash
#Add a new user

FINALCOMMAND="-m"

#import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]
do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME   
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND="$FINALCOMMAND ""-s $SHELL"
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND="$FINALCOMMAND --user-group"
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND="$FINALCOMMAND -g $newPrimaryGroup"
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND="$FINALCOMMAND --user-group"
    fi
fi
useradd -m --user-group jaredm2
#ASK about additional groups
echo "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=""
IFS=","
for g in $extraGroups
do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done
FINALEXTRAGROUPS=$(echo "$FINALEXTRAGROUPS" | tail -c +2)
if [ ${#FINALEXTRAGROUPS} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -G $FINALEXTRAGROUPS"
fi

#ASK about the home directory
echo "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -d $NEWHOME"
fi

#ADD the username to the command
FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`
echo "useradd $FINALCOMMAND"
#PASSCOMMAND="sudo passwd $USERNAME"
#ADD THE USER
`useradd $FINALCOMMAND`

`passwd $USERNAME`

`chfn $USERNAME`

更新:添加调试内容

+ '[' 0 -ge 1 ']'
++ sed 's/^ *//g'
++ sed 's/ *$//g'
++ echo '/usr/sbin/useradd -m -U JaredM'
+ FINALCOMMAND='/usr/sbin/useradd -m -U JaredM'
++ '/usr/sbin/useradd -m -U JaredM'
./addnewuser.sh: line 89: /usr/sbin/useradd -m -U JaredM: No such file or directory

Answer 1

通过使用数组，您可以防止命令行中与IFS相关的错误，而且它非常干净。这个已经测试过了。我也对代码做了些清理。

#!/bin/bash

#Add a new user

FINALCOMMAND=("-m")

#Import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]; do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-s" "$SHELL")
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo -n "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "--user-group")
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND=("${FINALCOMMAND[@]}" "-g" "$newPrimaryGroup")
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND=("${FINALCOMMAND[@]}" "--user-group")
    fi
fi

#ASK about additional groups
echo -n "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=''
IFS=, read -a TEMP <<< "$extraGroups"
for g in "${TEMP[@]}"; do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done

if [ ${#FINALEXTRAGROUPS[@]} -ge 1 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-G" "${FINALEXTRAGROUPS:1}")
fi


#ASK about the home directory
echo -n "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-d" "$NEWHOME")
fi

#ADD the username to the command
FINALCOMMAND=("${FINALCOMMAND[@]}" "$USERNAME")

#PASSCOMMAND="sudo passwd $USERNAME"

#ADD THE USER
echo "useradd ${FINALCOMMAND[@]}"

useradd "${FINALCOMMAND[@]}"

passwd "$USERNAME"

chfn "$USERNAME"

注意:在更新版本的bash中，只需使用+=将值附加到数组，例如ARRAY+=(" value ")

此外，通过我的附加首选项，我会以这种方式进一步改进代码，但这还不是最好的：

#!/bin/bash

shopt -s extglob

# Check if running as root.
if [[ "$(id -u)" != 0 ]]; then
    echo "This script must be ran as root."
    exit 1
fi

# Initialize useradd command variable.
USERADDCOMMAND=("useradd" "-m")

# Import useradd defaults.
. /etc/default/useradd

# Get the new user's name.
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read NAME

# Get the new users username.
echo "The username must be 4-20 characters."
while :; do
    read -p "Please enter the user's requested username and press [ENTER]: " USERNAME
    [[ ${#USERNAME} -ge 4 && ${#USERNAME} -le 20 && $USERNAME == +([[:alpha:]])*([[:alnum:]_-]) ]] || {
        echo "Error: Username is invalid. Please enter a different username."
        continue
    }
    [[ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ]] && {
        echo "Error: Username is in use. Please enter a different username."
        continue
    }
    break
done

# Ask about the default shell.
read -p "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: " SHELL_
if [[ ${#SHELL_} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-s" "$SHELL_")
else
    # We use this if we really are to use SHELL specified in $SHELL but it still needs further workarounds like checking if $SHELL is valid. Those could be easily done but it depends if this one's really necessary.
    #USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-s" "$SHELL")
    :
fi

# Ask about a different primary group.
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username."
echo -n "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read NEWPRIMARYGROUP

if [[ ${#NEWPRIMARYGROUP} -eq 0 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "--user-group")
else
    if [[ $(grep -c "^${NEWPRIMARYGROUP}" /etc/group) -ge 1 ]]; then
        USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-g" "$NEWPRIMARYGROUP")
    else
        echo "Invalid group specified reverting to default!"
        USERADDCOMMAND=("${USERADDCOMMAND[@]}" "--user-group")
    fi
fi

# Ask about additional groups.
echo -n "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read EXTRAGROUPS
# Remove spaces if the user entered any.
EXTRAGROUPS="${EXTRAGROUPS//[[:space:]]}"
FINALEXTRAGROUPS=''
IFS=, read -a TEMP <<< "$EXTRAGROUPS"
for G in "${TEMP[@]}"; do
    if [[ $(grep -c "^${g}" /etc/group) -ge 1 ]]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$G"
    else
        echo "$G is an invalid user and will not be added."
    fi
done
if [[ ${#FINALEXTRAGROUPS[@]} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-G" "${FINALEXTRAGROUPS:1}")
fi

# Ask about the home directory
read -p "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: " NEWHOME
if [[ ${#NEWHOME} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-d" "$NEWHOME")
fi

# Add the username to the command
USERADDCOMMAND=("${USERADDCOMMAND[@]}" "$USERNAME")

# Add THE USER
echo "> ${USERADDCOMMAND[*]}"
"${USERADDCOMMAND[@]}"

echo "> passwd $USERNAME"
passwd "$USERNAME"

echo "> chfn $USERNAME"
chfn "$USERNAME"  # -f "$NAME"

Answer 2

如果man -s8 useradd没有提到可用的--user-group选项，那么-U将无法工作。还有另一个值得尝试的解决方案：

默认行为(如果没有指定-g、-N和-U选项)是由/etc/login.defs中的USERGROUPS_ENAB变量定义的。

另一种方法是，您必须使用一个具有相同用户名的useradd命令来链接groupadd命令，该命令作为两个命令的参数。

编辑：必须工作。首先创建组，然后创建用户并将这个新用户添加到组中。因为，您是在脚本中这样做的--这应该是非常好的工作。

这样做：

groupadd jaredm2
useradd -m -g jaredm2 jaredm2

而不是这样：

useradd -m --user-group jaredm2

请注意，在您的操作系统中安装的某些其他程序可能更改了您的二进制程序或访问它，甚至为它创建了一个别名。您的which输出表明它链接到bin目录中的useradd二进制文件，这正是它应该在的位置。

所以我猜：

• 二进制文件可能已被进程、包安装程序或其他东西更改或替换。
• 二进制版本和手册版本之间存在一些不匹配(很可能是如果您在某个时候对操作系统进行了不适当的升级)。

我认为，唯一的解决方案是使用上面的命令或手动更改useradd二进制文件。

Answer 3

这个问题是由您的脚本引起的--您使用了`...`来执行您的​​命令，并使用了​​。

只有当您希望将返回的命令存储在变量中时，才应该使用这些引号:例如，下面的指令：

FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`

否则，它没有必要使用这个报价，他们可以产生像你这样的错误。

你可以把你的剧本：

useradd $FINALCOMMAND
passwd $USERNAME
chfn $USERNAME

而不是：

`useradd $FINALCOMMAND`
`passwd $USERNAME`
`chfn $USERNAME`