我正在致力于包装FindFirstFile/FindNextFile循环的丑陋内部(尽管我的问题也适用于其他类似的API,如RegEnumKeyEx或RegEnumValue等)。内部迭代器,其工作方式类似于标准模板库的istream_iterator。
我这里有两个问题。第一个是大多数"foreach“样式循环的终止条件。样式迭代器通常在for的退出条件中使用operator!=。
std::vector<int> test;
for(std::vector<int>::iterator it = test.begin(); it != test.end(); it++) {
//Do stuff
}我的问题是,我不确定如何使用这样的目录枚举实现operator!=,因为直到我实际完成枚举后,我才知道枚举何时完成。我现在有一种hack enumerates的解决方案,可以一次枚举整个目录,其中每个迭代器只跟踪一个引用计数的向量,但这看起来像是一件杂碎的事情,可以用更好的方式完成。
我遇到的第二个问题是FindXFile API返回了多个数据。因此,没有明显的方法来重载迭代器语义所需的operator*。当我重载该项目时,是否返回文件名?尺寸是多少?修改日期?我该如何以理想化的方式传递这样的迭代器稍后必须引用的多个数据段呢?我尝试过抄袭C#风格的MoveNext设计,但我担心没有遵循这里的标准习惯用法。
class SomeIterator {
public:
bool next(); //Advances the iterator and returns true if successful, false if the iterator is at the end.
std::wstring fileName() const;
//other kinds of data....
};编辑:调用者将如下所示:
SomeIterator x = ??; //Construct somehow
while(x.next()) {
//Do stuff
}谢谢!
Billy3
EDIT2:我已经修复了一些bug,并编写了一些测试。
实施:
#pragma once
#include <queue>
#include <string>
#include <boost/noncopyable.hpp>
#include <boost/make_shared.hpp>
#include <boost/iterator/iterator_facade.hpp>
#include <Windows.h>
#include <Shlwapi.h>
#pragma comment(lib, "shlwapi.lib")
#include "../Exception.hpp"
namespace WindowsAPI { namespace FileSystem {
template <typename Filter_T = AllResults, typename Recurse_T = NonRecursiveEnumeration>
class DirectoryIterator;
//For unit testing
struct RealFindXFileFunctions
{
static HANDLE FindFirst(LPCWSTR lpFileName, LPWIN32_FIND_DATAW lpFindFileData) {
return FindFirstFile(lpFileName, lpFindFileData);
};
static BOOL FindNext(HANDLE hFindFile, LPWIN32_FIND_DATAW lpFindFileData) {
return FindNextFile(hFindFile, lpFindFileData);
};
static BOOL Close(HANDLE hFindFile) {
return FindClose(hFindFile);
};
};
inline std::wstring::const_iterator GetLastSlash(std::wstring const&pathSpec) {
return std::find(pathSpec.rbegin(), pathSpec.rend(), L'\\').base();
}
class Win32FindData {
WIN32_FIND_DATA internalData;
std::wstring rootPath;
public:
Win32FindData(const std::wstring& root, const WIN32_FIND_DATA& data) :
rootPath(root), internalData(data) {};
DWORD GetAttributes() const {
return internalData.dwFileAttributes;
};
bool IsDirectory() const {
return (internalData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != 0;
};
bool IsFile() const {
return !IsDirectory();
};
unsigned __int64 GetSize() const {
ULARGE_INTEGER intValue;
intValue.LowPart = internalData.nFileSizeLow;
intValue.HighPart = internalData.nFileSizeHigh;
return intValue.QuadPart;
};
std::wstring GetFolderPath() const {
return rootPath;
};
std::wstring GetFileName() const {
return internalData.cFileName;
};
std::wstring GetFullFileName() const {
return rootPath + L"\\" + internalData.cFileName;
};
std::wstring GetShortFileName() const {
return internalData.cAlternateFileName;
};
FILETIME GetCreationTime() const {
return internalData.ftCreationTime;
};
FILETIME GetLastAccessTime() const {
return internalData.ftLastAccessTime;
};
FILETIME GetLastWriteTime() const {
return internalData.ftLastWriteTime;
};
};
template <typename FindXFileFunctions_T>
class BasicNonRecursiveEnumeration : public boost::noncopyable
{
WIN32_FIND_DATAW currentData;
HANDLE hFind;
std::wstring currentDirectory;
void IncrementCurrentDirectory() {
if (hFind == INVALID_HANDLE_VALUE) return;
BOOL success =
FindXFileFunctions_T::FindNext(hFind, ¤tData);
if (success)
return;
DWORD error = GetLastError();
if (error == ERROR_NO_MORE_FILES) {
FindXFileFunctions_T::Close(hFind);
hFind = INVALID_HANDLE_VALUE;
} else {
WindowsApiException::Throw(error);
}
};
bool IsValidDotDirectory()
{
return !Valid() &&
(!wcscmp(currentData.cFileName, L".") || !wcscmp(currentData.cFileName, L".."));
};
void IncrementPastDotDirectories() {
while (IsValidDotDirectory()) {
IncrementCurrentDirectory();
}
};
void PerformFindFirstFile(std::wstring const&pathSpec)
{
hFind = FindXFileFunctions_T::FindFirst(pathSpec.c_str(), ¤tData);
if (Valid()
&& GetLastError() != ERROR_PATH_NOT_FOUND
&& GetLastError() != ERROR_FILE_NOT_FOUND)
WindowsApiException::ThrowFromLastError();
};
public:
BasicNonRecursiveEnumeration() : hFind(INVALID_HANDLE_VALUE) {};
BasicNonRecursiveEnumeration(const std::wstring& pathSpec) :
hFind(INVALID_HANDLE_VALUE) {
std::wstring::const_iterator lastSlash = GetLastSlash(pathSpec);
if (lastSlash != pathSpec.begin())
currentDirectory.assign(pathSpec.begin(), lastSlash-1);
PerformFindFirstFile(pathSpec);
IncrementPastDotDirectories();
};
bool equal(const BasicNonRecursiveEnumeration<FindXFileFunctions_T>& other) const {
if (this == &other)
return true;
return hFind == other.hFind;
};
Win32FindData dereference() {
return Win32FindData(currentDirectory, currentData);
};
void increment() {
IncrementCurrentDirectory();
};
bool Valid() {
return hFind == INVALID_HANDLE_VALUE;
};
virtual ~BasicNonRecursiveEnumeration() {
if (!Valid())
FindXFileFunctions_T::Close(hFind);
};
};
typedef BasicNonRecursiveEnumeration<RealFindXFileFunctions> NonRecursiveEnumeration;
template <typename FindXFileFunctions_T>
class BasicRecursiveEnumeration : public boost::noncopyable
{
std::wstring fileSpec;
std::deque<std::deque<Win32FindData> > enumeratedData;
void EnumerateDirectory(const std::wstring& nextPathSpec) {
std::deque<Win32FindData> newDeck;
BasicNonRecursiveEnumeration<FindXFileFunctions_T> begin(nextPathSpec), end;
for(; !begin.equal(end); begin.increment()) {
newDeck.push_back(begin.dereference());
}
if (!newDeck.empty()) {
enumeratedData.push_back(std::deque<Win32FindData>()); //Swaptimization
enumeratedData.back().swap(newDeck);
}
};
void PerformIncrement() {
if (enumeratedData.empty()) return;
if (enumeratedData.back().front().IsDirectory()) {
std::wstring nextSpec(enumeratedData.back().front().GetFullFileName());
nextSpec.append(L"\\*");
enumeratedData.back().pop_front();
EnumerateDirectory(nextSpec);
} else {
enumeratedData.back().pop_front();
}
while (Valid() && enumeratedData.back().empty())
enumeratedData.pop_back();
}
bool CurrentPositionNoMatchFileSpec() const
{
return !enumeratedData.empty() && !PathMatchSpecW(enumeratedData.back().front().GetFileName().c_str(), fileSpec.c_str());
}
public:
BasicRecursiveEnumeration() {};
BasicRecursiveEnumeration(const std::wstring& pathSpec) {
std::wstring::const_iterator lastSlash = GetLastSlash(pathSpec);
if (lastSlash == pathSpec.begin()) {
fileSpec = pathSpec;
EnumerateDirectory(L"*");
} else {
fileSpec.assign(lastSlash, pathSpec.end());
std::wstring firstQuery(pathSpec.begin(), lastSlash);
firstQuery.push_back(L'*');
EnumerateDirectory(firstQuery);
while (CurrentPositionNoMatchFileSpec())
PerformIncrement();
}
};
void increment() {
do
{
PerformIncrement();
} while (CurrentPositionNoMatchFileSpec());
};
bool equal(const BasicRecursiveEnumeration<FindXFileFunctions_T>& other) const {
if (!Valid())
return !other.Valid();
if (!other.Valid())
return false;
return this == &other;
};
Win32FindData dereference() const {
return enumeratedData.back().front();
};
bool Valid() const {
return !enumeratedData.empty();
};
};
typedef BasicRecursiveEnumeration<RealFindXFileFunctions> RecursiveEnumeration;
struct AllResults
{
bool operator()(const Win32FindData&) {
return true;
};
};
struct FilesOnly
{
bool operator()(const Win32FindData& arg) {
return arg.IsFile();
};
};
template <typename Filter_T, typename Recurse_T>
class DirectoryIterator :
public boost::iterator_facade<
DirectoryIterator<Filter_T, Recurse_T>,
Win32FindData,
std::input_iterator_tag,
Win32FindData
>
{
friend class boost::iterator_core_access;
boost::shared_ptr<Recurse_T> impl;
Filter_T filter;
void increment() {
do {
impl->increment();
} while (impl->Valid() && !filter(impl->dereference()));
};
bool equal(const DirectoryIterator& other) const {
return impl->equal(*other.impl);
};
Win32FindData dereference() const {
return impl->dereference();
};
public:
DirectoryIterator(Filter_T functor = Filter_T()) :
impl(boost::make_shared<Recurse_T>()),
filter(functor) {
};
explicit DirectoryIterator(const std::wstring& pathSpec, Filter_T functor = Filter_T()) :
impl(boost::make_shared<Recurse_T>(pathSpec)),
filter(functor) {
};
};
}}测试:
#include <queue>
#include "../WideCharacterOutput.hpp"
#include <boost/test/unit_test.hpp>
#include "../../WindowsAPI++/FileSystem/Enumerator.hpp"
using namespace WindowsAPI::FileSystem;
struct SimpleFakeFindXFileFunctions
{
static std::deque<WIN32_FIND_DATAW> fakeData;
static std::wstring insertedFileName;
static HANDLE FindFirst(LPCWSTR lpFileName, LPWIN32_FIND_DATAW lpFindFileData) {
insertedFileName.assign(lpFileName);
if (fakeData.empty()) {
SetLastError(ERROR_PATH_NOT_FOUND);
return INVALID_HANDLE_VALUE;
}
*lpFindFileData = fakeData.front();
fakeData.pop_front();
return reinterpret_cast<HANDLE>(42);
};
static BOOL FindNext(HANDLE hFindFile, LPWIN32_FIND_DATAW lpFindFileData) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
if (fakeData.empty()) {
SetLastError(ERROR_NO_MORE_FILES);
return 0;
}
*lpFindFileData = fakeData.front();
fakeData.pop_front();
return 1;
};
static BOOL Close(HANDLE hFindFile) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
return 1;
};
};
std::deque<WIN32_FIND_DATAW> SimpleFakeFindXFileFunctions::fakeData;
std::wstring SimpleFakeFindXFileFunctions::insertedFileName;
struct ErroneousFindXFileFunctionFirst
{
static HANDLE FindFirst(LPCWSTR, LPWIN32_FIND_DATAW) {
SetLastError(ERROR_ACCESS_DENIED);
return INVALID_HANDLE_VALUE;
};
static BOOL FindNext(HANDLE hFindFile, LPWIN32_FIND_DATAW) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
return 1;
};
static BOOL Close(HANDLE hFindFile) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
return 1;
};
};
struct ErroneousFindXFileFunctionNext
{
static HANDLE FindFirst(LPCWSTR, LPWIN32_FIND_DATAW) {
return reinterpret_cast<HANDLE>(42);
};
static BOOL FindNext(HANDLE hFindFile, LPWIN32_FIND_DATAW) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
SetLastError(ERROR_INVALID_PARAMETER);
return 0;
};
static BOOL Close(HANDLE hFindFile) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
return 1;
};
};
struct DirectoryIteratorTestsFixture
{
typedef SimpleFakeFindXFileFunctions fakeFunctor;
DirectoryIteratorTestsFixture() {
WIN32_FIND_DATAW test;
wcscpy_s(test.cFileName, L".");
wcscpy_s(test.cAlternateFileName, L".");
test.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
GetSystemTimeAsFileTime(&test.ftCreationTime);
test.ftLastWriteTime = test.ftCreationTime;
test.ftLastAccessTime = test.ftCreationTime;
test.nFileSizeHigh = 0;
test.nFileSizeLow = 0;
fakeFunctor::fakeData.push_back(test);
wcscpy_s(test.cFileName, L"..");
wcscpy_s(test.cAlternateFileName, L"..");
fakeFunctor::fakeData.push_back(test);
wcscpy_s(test.cFileName, L"File.txt");
wcscpy_s(test.cAlternateFileName, L"FILE.TXT");
test.nFileSizeLow = 1024;
test.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
fakeFunctor::fakeData.push_back(test);
wcscpy_s(test.cFileName, L"System32");
wcscpy_s(test.cAlternateFileName, L"SYSTEM32");
test.nFileSizeLow = 0;
test.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
fakeFunctor::fakeData.push_back(test);
};
~DirectoryIteratorTestsFixture() {
fakeFunctor::fakeData.clear();
};
};
BOOST_FIXTURE_TEST_SUITE( DirectoryIteratorTests, DirectoryIteratorTestsFixture )
template<typename fakeFunctor>
static void NonRecursiveIteratorAssertions()
{
typedef DirectoryIterator<AllResults
,BasicNonRecursiveEnumeration<SimpleFakeFindXFileFunctions> > testType;
testType begin(L"C:\\Windows\\*");
testType end;
BOOST_CHECK_EQUAL(fakeFunctor::insertedFileName, L"C:\\Windows\\*");
BOOST_CHECK(begin->GetFolderPath() == L"C:\\Windows");
BOOST_CHECK(begin->GetFileName() == L"File.txt");
BOOST_CHECK(begin->GetFullFileName() == L"C:\\Windows\\File.txt");
BOOST_CHECK(begin->GetShortFileName() == L"FILE.TXT");
BOOST_CHECK_EQUAL(begin->GetSize(), 1024);
BOOST_CHECK(begin->IsFile());
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->GetFileName() == L"System32");
BOOST_CHECK(begin->GetFullFileName() == L"C:\\Windows\\System32");
BOOST_CHECK(begin->GetShortFileName() == L"SYSTEM32");
BOOST_CHECK_EQUAL(begin->GetSize(), 0);
BOOST_CHECK(begin->IsDirectory());
begin++;
BOOST_CHECK(begin == end);
}
BOOST_AUTO_TEST_CASE( BasicEnumeration )
{
NonRecursiveIteratorAssertions<fakeFunctor>();
}
BOOST_AUTO_TEST_CASE( NoRootDirectories )
{
fakeFunctor::fakeData.pop_front();
fakeFunctor::fakeData.pop_front();
NonRecursiveIteratorAssertions<fakeFunctor>();
}
static void EmptyIteratorAssertions() {
typedef DirectoryIterator<AllResults
,BasicNonRecursiveEnumeration<SimpleFakeFindXFileFunctions> > testType;
testType begin(L"C:\\Windows\\*");
testType end;
BOOST_CHECK(begin == end);
}
BOOST_AUTO_TEST_CASE( Empty1 )
{
fakeFunctor::fakeData.clear();
EmptyIteratorAssertions();
}
BOOST_AUTO_TEST_CASE( Empty2 )
{
fakeFunctor::fakeData.erase(fakeFunctor::fakeData.begin() + 2, fakeFunctor::fakeData.end());
EmptyIteratorAssertions();
}
BOOST_AUTO_TEST_CASE( CorrectDestruction )
{
typedef DirectoryIterator<AllResults
,BasicNonRecursiveEnumeration<SimpleFakeFindXFileFunctions> > testType;
testType begin(L"C:\\Windows\\*");
testType end;
}
BOOST_AUTO_TEST_CASE( Exceptions )
{
typedef DirectoryIterator<AllResults,BasicNonRecursiveEnumeration<ErroneousFindXFileFunctionFirst> >
firstFailType;
BOOST_CHECK_THROW(firstFailType(L"C:\\Windows\\*"), WindowsAPI::ErrorAccessDeniedException);
typedef DirectoryIterator<AllResults,BasicNonRecursiveEnumeration<ErroneousFindXFileFunctionNext> >
nextFailType;
nextFailType constructedOkay(L"C:\\Windows\\*");
BOOST_CHECK_THROW(constructedOkay++, WindowsAPI::ErrorInvalidParameterException);
}
BOOST_AUTO_TEST_SUITE_END()
struct RecursiveFakeFindXFileFunctions
{
static std::deque<std::pair<std::deque<WIN32_FIND_DATA> , std::wstring> > fakeData;
static std::size_t openHandles;
static HANDLE FindFirst(LPCWSTR lpFileName, LPWIN32_FIND_DATAW lpFindFileData) {
BOOST_REQUIRE(!fakeData.empty());
BOOST_REQUIRE_EQUAL(lpFileName, fakeData.front().second);
openHandles++;
BOOST_REQUIRE_EQUAL(openHandles, 1);
if (fakeData.front().first.empty()) {
openHandles--;
SetLastError(ERROR_PATH_NOT_FOUND);
return INVALID_HANDLE_VALUE;
}
*lpFindFileData = fakeData.front().first.front();
fakeData.front().first.pop_front();
return reinterpret_cast<HANDLE>(42);
};
static BOOL FindNext(HANDLE hFindFile, LPWIN32_FIND_DATAW lpFindFileData) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
if (fakeData.front().first.empty()) {
SetLastError(ERROR_NO_MORE_FILES);
return 0;
}
*lpFindFileData = fakeData.front().first.front();
fakeData.front().first.pop_front();
return 1;
};
static BOOL Close(HANDLE hFindFile) {
BOOST_CHECK_EQUAL(reinterpret_cast<HANDLE>(42), hFindFile);
openHandles--;
BOOST_REQUIRE_EQUAL(openHandles, 0);
fakeData.pop_front();
return 1;
};
};
std::deque<std::pair<std::deque<WIN32_FIND_DATA> , std::wstring> > RecursiveFakeFindXFileFunctions::fakeData;
std::size_t RecursiveFakeFindXFileFunctions::openHandles;
struct RecursiveDirectoryFixture
{
RecursiveDirectoryFixture() {
WIN32_FIND_DATAW tempData;
ZeroMemory(&tempData, sizeof(tempData));
std::deque<WIN32_FIND_DATAW> dequeData;
wcscpy_s(tempData.cFileName, L".");
wcscpy_s(tempData.cAlternateFileName, L".");
tempData.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
GetSystemTimeAsFileTime(&tempData.ftCreationTime);
tempData.ftLastWriteTime = tempData.ftCreationTime;
tempData.ftLastAccessTime = tempData.ftCreationTime;
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"..");
wcscpy_s(tempData.cAlternateFileName, L"..");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"MySubDirectory");
wcscpy_s(tempData.cAlternateFileName, L"MYSUBD~1");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"MyFile.txt");
wcscpy_s(tempData.cAlternateFileName, L"MYFILE.TXT");
tempData.nFileSizeLow = 500;
tempData.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
dequeData.push_back(tempData);
RecursiveFakeFindXFileFunctions::fakeData.push_back
(std::make_pair(dequeData, L"C:\\Windows\\*"));
dequeData.clear();
wcscpy_s(tempData.cFileName, L".");
wcscpy_s(tempData.cAlternateFileName, L".");
tempData.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
GetSystemTimeAsFileTime(&tempData.ftCreationTime);
tempData.ftLastWriteTime = tempData.ftCreationTime;
tempData.ftLastAccessTime = tempData.ftCreationTime;
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"..");
wcscpy_s(tempData.cAlternateFileName, L"..");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"MyFile2.txt");
wcscpy_s(tempData.cAlternateFileName, L"NYFILE2.TXT");
tempData.nFileSizeLow = 1024;
tempData.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
dequeData.push_back(tempData);
RecursiveFakeFindXFileFunctions::fakeData.push_back
(std::make_pair(dequeData, L"C:\\Windows\\MySubDirectory\\*"));
};
~RecursiveDirectoryFixture() {
RecursiveFakeFindXFileFunctions::fakeData.clear();
};
};
BOOST_AUTO_TEST_SUITE( RecursiveDirectoryIteratorTests )
BOOST_AUTO_TEST_CASE( BasicEnumerationTxt )
{
RecursiveDirectoryFixture DataFixture;
typedef DirectoryIterator<AllResults
,BasicRecursiveEnumeration<RecursiveFakeFindXFileFunctions> > testType;
testType begin(L"C:\\Windows\\*.txt");
testType end;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 1024);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows\\MySubDirectory");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MyFile2.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MySubDirectory\\MyFile2.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 500);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MyFile.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MyFile.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin == end);
}
BOOST_AUTO_TEST_CASE( BasicEnumerationAll )
{
RecursiveDirectoryFixture DataFixture;
typedef DirectoryIterator<AllResults
,BasicRecursiveEnumeration<RecursiveFakeFindXFileFunctions> > testType;
testType begin(L"C:\\Windows\\*");
testType end;
BOOST_CHECK(begin->IsDirectory());
BOOST_CHECK_EQUAL(begin->GetSize(), 0);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MySubDirectory");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MySubDirectory");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 1024);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows\\MySubDirectory");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MyFile2.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MySubDirectory\\MyFile2.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 500);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MyFile.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MyFile.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin == end);
}
BOOST_AUTO_TEST_CASE( RecursionOrderMaintained )
{
WIN32_FIND_DATAW tempData;
ZeroMemory(&tempData, sizeof(tempData));
std::deque<WIN32_FIND_DATAW> dequeData;
wcscpy_s(tempData.cFileName, L".");
wcscpy_s(tempData.cAlternateFileName, L".");
tempData.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
GetSystemTimeAsFileTime(&tempData.ftCreationTime);
tempData.ftLastWriteTime = tempData.ftCreationTime;
tempData.ftLastAccessTime = tempData.ftCreationTime;
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"..");
wcscpy_s(tempData.cAlternateFileName, L"..");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"MySubDirectory");
wcscpy_s(tempData.cAlternateFileName, L"MYSUBD~1");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"MyFile.txt");
wcscpy_s(tempData.cAlternateFileName, L"MYFILE.TXT");
tempData.nFileSizeLow = 500;
tempData.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"Zach");
wcscpy_s(tempData.cAlternateFileName, L"ZACH");
tempData.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
tempData.nFileSizeLow = 0;
dequeData.push_back(tempData);
RecursiveFakeFindXFileFunctions::fakeData.push_back
(std::make_pair(dequeData, L"C:\\Windows\\*"));
dequeData.clear();
wcscpy_s(tempData.cFileName, L".");
wcscpy_s(tempData.cAlternateFileName, L".");
tempData.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
GetSystemTimeAsFileTime(&tempData.ftCreationTime);
tempData.ftLastWriteTime = tempData.ftCreationTime;
tempData.ftLastAccessTime = tempData.ftCreationTime;
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"..");
wcscpy_s(tempData.cAlternateFileName, L"..");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"MyFile2.txt");
wcscpy_s(tempData.cAlternateFileName, L"NYFILE2.TXT");
tempData.nFileSizeLow = 1024;
tempData.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
dequeData.push_back(tempData);
RecursiveFakeFindXFileFunctions::fakeData.push_back
(std::make_pair(dequeData, L"C:\\Windows\\MySubDirectory\\*"));
dequeData.clear();
wcscpy_s(tempData.cFileName, L".");
wcscpy_s(tempData.cAlternateFileName, L".");
tempData.dwFileAttributes = FILE_ATTRIBUTE_DIRECTORY;
GetSystemTimeAsFileTime(&tempData.ftCreationTime);
tempData.ftLastWriteTime = tempData.ftCreationTime;
tempData.ftLastAccessTime = tempData.ftCreationTime;
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"..");
wcscpy_s(tempData.cAlternateFileName, L"..");
dequeData.push_back(tempData);
wcscpy_s(tempData.cFileName, L"ZachFile.txt");
wcscpy_s(tempData.cAlternateFileName, L"ZACHFILE.TXT");
tempData.nFileSizeLow = 1024;
tempData.dwFileAttributes = FILE_ATTRIBUTE_NORMAL;
dequeData.push_back(tempData);
RecursiveFakeFindXFileFunctions::fakeData.push_back
(std::make_pair(dequeData, L"C:\\Windows\\Zach\\*"));
typedef DirectoryIterator<AllResults
,BasicRecursiveEnumeration<RecursiveFakeFindXFileFunctions> > testType;
testType begin(L"C:\\Windows\\*");
testType end;
BOOST_CHECK(begin->IsDirectory());
BOOST_CHECK_EQUAL(begin->GetSize(), 0);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MySubDirectory");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MySubDirectory");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 1024);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows\\MySubDirectory");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MyFile2.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MySubDirectory\\MyFile2.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 500);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"MyFile.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\MyFile.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsDirectory());
BOOST_CHECK_EQUAL(begin->GetSize(), 0);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"Zach");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\Zach");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin->IsFile());
BOOST_CHECK_EQUAL(begin->GetSize(), 1024);
BOOST_CHECK_EQUAL(begin->GetFolderPath(), L"C:\\Windows\\Zach");
BOOST_CHECK_EQUAL(begin->GetFileName(), L"ZachFile.txt");
BOOST_CHECK_EQUAL(begin->GetFullFileName(), L"C:\\Windows\\Zach\\ZachFile.txt");
BOOST_CHECK(begin != end);
begin++;
BOOST_CHECK(begin == end);
}
BOOST_AUTO_TEST_CASE( Exceptions )
{
typedef DirectoryIterator<AllResults,BasicRecursiveEnumeration<ErroneousFindXFileFunctionFirst> >
firstFailType;
BOOST_CHECK_THROW(firstFailType(L"C:\\Windows\\*"), WindowsAPI::ErrorAccessDeniedException);
typedef DirectoryIterator<AllResults,BasicRecursiveEnumeration<ErroneousFindXFileFunctionNext> >
nextFailType;
BOOST_CHECK_THROW(nextFailType(L"C:\\Windows\\*"), WindowsAPI::ErrorInvalidParameterException);
}
BOOST_AUTO_TEST_SUITE_END()发布于 2010-03-28 12:38:18
有趣的是,不久前我也有同样的想法。下面是我写的内容:
#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#include <string>
#include <iterator>
#include <exception>
#ifndef DIR_ITERATOR_H_INC
#define DIR_ITERATOR_H_INC
class dir_iterator
#if (!defined(_MSC_VER)) || (_MSC_VER > 1200)
: public std::iterator<std::input_iterator_tag,
std::string,
int,
std::string *,
std::string &>
#endif
{
mutable HANDLE it;
std::string mask;
std::string path;
WIN32_FIND_DATA data;
bool done;
DWORD require;
DWORD prohibit;
public:
WIN32_FIND_DATA operator*() {
return data;
}
dir_iterator(dir_iterator const &other) :
it(other.it),
mask(other.mask),
path(other.path),
data(other.data),
done(other.done),
require(other.require),
prohibit(other.prohibit)
{
// Transfer the handle instead of just copying it.
other.it=INVALID_HANDLE_VALUE;
}
dir_iterator(std::string const &s,
DWORD must = 0,
DWORD cant = FILE_ATTRIBUTE_DIRECTORY)
: mask(s),
require(must),
prohibit(cant & ~must),
done(false),
it(INVALID_HANDLE_VALUE) // To fix bug spotted by Billy ONeal.
{
int pos;
if (std::string::npos != (pos=mask.find_last_of("\\/")))
path = std::string(mask, 0, pos+1);
it = FindFirstFile(mask.c_str(), &data);
if (it == INVALID_HANDLE_VALUE)
throw std::invalid_argument("Directory Inaccessible");
while (!(((data.dwFileAttributes & require) == require) &&
((data.dwFileAttributes & prohibit) == 0)))
{
if (done = (FindNextFile(it, &data)==0))
break;
}
}
dir_iterator() : done(true) {}
dir_iterator &operator++() {
do {
if (done = (FindNextFile(it, &data)==0))
break;
} while (!(((data.dwFileAttributes & require) == require) &&
(data.dwFileAttributes & prohibit) == 0));
return *this;
}
bool operator!=(dir_iterator const &other) {
return done != other.done;
}
bool operator==(dir_iterator const &other) {
return done == other.done;
}
~dir_iterator() {
// The rest of the bug fix -- only close handle if it's open.
if (it!=INVALID_HANDLE_VALUE)
FindClose(it);
}
};
#endif下面是一个快速演示:
#include "dir_iterator.h"
#include <iostream>
#include <algorithm>
namespace std {
std::ostream &operator<<(std::ostream &os, WIN32_FIND_DATA const &d) {
return os << d.cFileName;
}
}
int main() {
std::copy(dir_iterator("*"), dir_iterator(),
std::ostream_iterator<WIN32_FIND_DATA>(std::cout, "\n"));
std::cout << "\nDirectories:\n";
std::copy(dir_iterator("*", FILE_ATTRIBUTE_DIRECTORY), dir_iterator(),
std::ostream_iterator<WIN32_FIND_DATA>(std::cout, "\n"));
return 0;
}发布于 2010-03-28 12:22:17
要解决第一个问题,可以让end()返回一些标记值,然后在迭代器的增量函数中,当迭代器到达容器的末尾时,将迭代器设置为等于该标记值。这实际上就是Boost.Filesystem中的目录迭代器所做的事情。
对于第二个问题,我并不完全熟悉FindXFile API,但是一种选择是返回一些结构,该结构包含您需要的所有数据,或者具有成员函数来获取您可能需要的每一段数据。
发布于 2010-03-28 12:37:23
Matthew Wilson写了几篇关于使目录枚举适应STL迭代器的文章。不幸的是,直接讨论Windows API的文章似乎不再在线。但是,我认为他在其他一些文章中讨论的想法可能仍然非常相关,而且他还提供了一个开源库(WinSTL - http://winstl.org/)。
此外,我相信Boost::Filesystem source and documentation是一个很好的想法来源。
https://stackoverflow.com/questions/2531874
复制相似问题