Python学习类的简单卡片游戏

Question

我正在尝试创建一个简单的纸牌游戏，以更好地理解OOP和类。

这个游戏是这样的:一副牌中有两张牌。然后发第三张牌。如果第三张牌在前两张牌之间，则玩家获胜。如果第三张牌等于前两张牌中的任何一张，或者在这套牌之外，那么玩家就输了。

这就是我到目前为止所知道的：

class Deck(object):
    def __init__(self):
        self.deck = []

    def PopulateDeck(self):
        suits = ["Hearts", "Diamonds", "Clubs", "Spades"]
        for suit in suits:
            for rank in range(2, 15):
                if rank == 11:
                    value = "Jack"
                elif rank == 12:
                    value = "Queen"
                elif rank == 13:
                    value = "King"
                elif rank == 14:
                    value = "Ace"

                self.deck.append(str(value) + " of " + suit)

class Card(object):
    def __init__(self, rank, value):
        self.rank = rank
        self.value = value
        self.card = self.rank + self.value

我在使用类和OOP时遇到了困难，我不确定这是不是一个好的开始，或者我下一步应该去哪里。其中很大一部分是通过阅读其他来源和示例创建的。有没有人能给我提个建议，我想做什么其他的类来运行我的游戏，以及这些类如何相互交互/继承？谢谢。

Answer 1

这更像是一次代码/方法审查。纸牌游戏是一种组合，而不是继承；Deck包含Card，但本身不是Card的类型，反之亦然。

我认为您正在复制Card中的信息。只需存储suit和排名，并使用__str__创建'x of y'。您还可以实现rich comparison methods

class Card(object):

    FACES = {11: 'Jack', 12: 'Queen', 13: 'King', 14: 'Ace'}

    def __init__(self, rank, suit):
        self.suit = suit
        self.rank = rank

    def __str__(self):
        value = self.FACES.get(self.rank, self.rank)
        return "{0} of {1}".format(value, self.suit)

    def __lt__(self, other):
        return self.rank < other.rank

现在，例如str(Card(13, 'Clubs')) == "King of Clubs"。这样就不会在card中重复rank和value。

接下来，我认为Deck应该在__init__中包含种群生成；您可以为非标准平台提供可选参数。我已经包含了两个实现；注释掉的版本是一个列表理解，使用itertools在一行中完成相同的工作。我还提供了一个函数来从self.deck中挑选n不同的随机卡片。

from itertools import product 
import random

class Deck(object):

    def __init__(self, ranks=None, suits=None):
        if ranks is None:
            ranks = range(2, 15)
        if suits is None:
            suits = ['Clubs', 'Diamonds', 'Hearts', 'Spades']
##        self.deck = [Card(r, s) for r, s in product(ranks, suits)]
        self.deck = []
        for r in ranks:
            for s in suits:
                self.deck.append(Card(r, s))

    def deal(self, n):
        return random.sample(self.deck, n)

现在游戏很简单；你可以每手发三张牌，然后自然地比较这些牌(例如使用<)，因为有比较的方法。

deck = Deck()
hand = deck.deal(3)
print(" - ".join(map(str, hand)))
if min(hand[0], hand[1]) < hand[2] < max(hand[0], hand[1]):
    print("Winner!")
else:
    print("Loser.")

Answer 2

正如@tobias_k在评论中指出的那样+我的一些想法

class Deck(object):
    def __init__(self):
        self.deck = []
        self.dealt = [] #Prevents from dealing the same card

    def PopulateDeck(self):
        suits = ["Hearts", "Diamonds", "Clubs", "Spades"]
        for suit in suits:
            for rank in range(2, 15):
                if rank == 11:
                    value = "Jack"
                elif rank == 12:
                    value = "Queen"
                elif rank == 13:
                    value = "King"
                elif rank == 14:
                    value = "Ace"
                else:
                    value = str(rank)

                self.deck.append(Card(value, suit))

    def deal(self):
        #Randomly select card
        remaining_cards = [card for card in self.deck if card not in self.dealt]
        card_index = random.randrange(0, len(remaining_cards)-1)
        card = remaining_cards[card_index]
        self.dealt.append(card)
        return card



    def shuffle(self):
        self.dealt = []

class Card(object):
    def __init__(self, rank, suit):
        self.rank = rank
        self.suit = suit
        self.card = str(self.rank) + " " + str(self.suit)
    def __eq__(self, other):
        return self.rank == other.rank and self.suit == other.suit

def play():
    deck = Deck()
    card1 = deck.deal()
    card2 = deck.deal()
    card3 = deck.deal()

#And here you will compare the cards to see if the player wins or not. Not sure 
#what exact criterion you're using.

deck.shuffle() #And leave your deck nicely shuffled for next game

play()

Random documentation

我还没有运行过这段代码，它很可能包含错误。但这是你能做什么的一个例证。

Answer 3

我也在使用纸牌游戏学习opps，因为我发现这是理解概念的最简单的方法。我曾经遇到过这段代码，但对链接不太确定。我用很少有用的注释来纠缠这段代码。这可能会有所帮助。

from random import shuffle
class Card:
    suits = ['spades', 'hearts',  'diamonds', 'clubs']
    values = [None, None, '2','3','4','5','6','7','8','9','10','Jack', 'Queen', 'King', 'Ace']

    def __init__(self, v, s):
        '''suits + values are ints'''
        self.value = v
        self.suit = s

    def __lt__(self, c2): # allows to compare two objects cards in this case
        if self.value < c2.value:
            return True
        if self.value == c2.value: # value is what user is putting while creating object of class
            if self.suit < c2.suit: # c2 is with what we are comapring
                return True
            else:
                return False
        return False

    def __gt__(self, c2): # allows to compare two objects cards in this case,
        if self.value > c2.value: # c2 is with what we are comapring
            return True
        if self.value == c2.value:
            if self.suit > c2.suit: # suits comes into picture if values are same suit number is given importance
                return True
            else:
                return False
        return False

    def __repr__(self):
        v = self.values[self.value] + ' of ' + self.suits[self.suit]
        return v


# defining the class which represent the deck of card

class Deck:
    def __init__(self):
        self.cards = []
        for i in range(2,15):
            for j in range(4):
                self.cards.append(Card(i,j))

        shuffle(self.cards)

    def rm_card(self):
        if len(self.cards) == 0:
            return  # if block it return to None object when condition is satisfied

        return self.cards.pop()

class Player:
    def __init__(self, name):
        self.name = name # name of the player
        self.card = None # current card player holding
        self.wins = 0

class Game:
    def __init__(self):
        name1 = input('p1 name ')
        name2 = input('p2 name ')
        self.deck = Deck()
        self.p1 = Player(name1)
        self.p2 = Player(name2)

    def wins(self, winner):
        w = "{} wins this round"
        w = w.format(winner)
        print(w)

    def draw(self, p1n, p1c, p2n, p2c):
        d = "{} drew {} {} drew {}"
        d = d.format(p1n, p1c, p2n, p2c)
        print(d)

    def play_game(self):
        cards = self.deck.cards  # self.deck = Deck() and cards = self.deck.cards is list of card
        print('Beginning War!!!')
        while len(cards) > 2:
            m = 'q to quit. Any' + ' key to play'
            response = input(m)
            if response == 'q':
                break
            p1c = self.deck.rm_card() # removing first card from deck by player 1
            p2c = self.deck.rm_card() # removing second card from deck by player 2
            p1n = self.p1.name
            p2n = self.p2.name
            self.draw(p1n, p1c, p2n, p2c)

            if p1c > p2c:
                self.p1.wins +=1
                self.wins(self.p1.name)
            else:
                self.p2.wins += 1
                self.wins(self.p2.name)

        win = self.winner(self.p1, self.p2)
        print("War is over. {} wins".format(win))

    def winner(self, p1, p2):
        if p1.wins > p2.wins:
            return p1.name
        if p1.wins < p2.wins:
            return p2.name




        return 'Its Tie!'
game = Game()
game.play_game()

来源：https://thecleverprogrammer.com/2020/10/04/card-game-with-python/